[MPlayer-dev-eng] PATCH] conditionally mark some VCD functions as static

[Reimar Döffinger]

On Sat, Feb 27, 2010 at 02:28:17PM +0100, Diego Biurrun wrote:
> Attached patch marks another VCD-related function as static when
> compiling without GUI support and works around the -Wmissing-decls
> warning when the GUI is enabled.
> 
> I know it is supremely ugly and I would not normally propose it,
> but I have come to think it's better to expose the GUI ugliness than
> to sweep it under the rug.  Also, if some day the GUI is removed,
> the ugliness goes away and the fix is remembered.

Well. I actually think this is not just a GUI ugliness, this feature
is not available for command-line MPlayer at all!
stream_cdda was fixed to expose this via STREAM_CTRL_SEEK_TO_CHAPTER,
after that the gui code can either be switched to that or that part
can just be removed.