[MPlayer-dev-eng] PATCH] conditionally mark some VCD functions as static
komh at chollian.net
Sun Feb 28 12:18:20 CET 2010
Diego Biurrun wrote:
> Attached patch marks another VCD-related function as static when
> compiling without GUI support and works around the -Wmissing-decls
> warning when the GUI is enabled.
> I know it is supremely ugly and I would not normally propose it,
> but I have come to think it's better to expose the GUI ugliness than
> to sweep it under the rug. Also, if some day the GUI is removed,
> the ugliness goes away and the fix is remembered.
> Index: stream/vcd_read.h
> --- stream/vcd_read.h (revision 30759)
> +++ stream/vcd_read.h (working copy)
> @@ -23,6 +23,7 @@
> #include <string.h>
> #include <errno.h>
> #include <sys/ioctl.h>
> +#include "config.h"
> #include "mp_msg.h"
> #include "stream.h"
> #include "libavutil/intreadwrite.h"
Why do you include config.h here again in spite of stream_vcd.c
including it already.
Using Mozilla SeaMonkey 2.0
Under OS/2 Warp 4 for Korean with FixPak #15
On Intel Core2Duo T5500 1.66 GHz with 1 GB RAM
Korean OS/2 User Community : http://www.ecomstation.co.kr
More information about the MPlayer-dev-eng