[MPlayer-dev-eng] [PATCH] -geometry option: support negative coordinates in 0x0+0+0 and +0+0 notation
melchior.franz at gmail.com
Tue Feb 23 00:19:55 CET 2010
* Reimar Döffinger -- Monday 22 February 2010:
> On Mon, Feb 22, 2010 at 04:56:19PM +0100, Melchior FRANZ wrote:
> Bad idea, that makes it impossible to distinguish the output from
> > -#define RESET_GEOMETRY width = height = xoff = yoff = xper = yper = INT_MIN;
> > +#define RESET_GEOMETRY width = height = xoff = yoff = xper = yper = INT_MIN, *xsign = *ysign = '\0';
> Just use a ";", there's no need to use "," here.
It's not a matter of "need", but of style. A comma is better style IMHO.
Burying a semicolon in the middle of other code is ugly (except in a "for"
statement, of course). But I don't care either way. :-)
Thanks for the review!
More information about the MPlayer-dev-eng