[MPlayer-dev-eng] [PATCH] -geometry option: support negative coordinates in 0x0+0+0 and +0+0 notation

Reimar Döffinger Reimar.Doeffinger at gmx.de
Mon Feb 22 20:12:21 CET 2010


On Mon, Feb 22, 2010 at 04:56:19PM +0100, Melchior FRANZ wrote:
> Minor improvement: the mp_msg() looks a tad cleaner if it doesn't output
> an empty space for a missing sign, using %s instead of %c.

Bad idea, that makes it impossible to distinguish the output from
+-100
and
-100

> -#define RESET_GEOMETRY width = height = xoff = yoff = xper = yper = INT_MIN;
> +#define RESET_GEOMETRY width = height = xoff = yoff = xper = yper = INT_MIN, *xsign = *ysign = '\0';

Just use a ";", there's no need to use "," here.
Otherwise I think it's ok.



More information about the MPlayer-dev-eng mailing list