[MPlayer-dev-eng] [PATCH] CDDB support for OS/2

[Reimar Döffinger]

On Fri, Feb 19, 2010 at 10:28:47PM +0900, KO Myung-Hun wrote:
> >>@@ -340,7 +423,7 @@
> >>  	sprintf( file_name, "%s%08lx", cddb_data->cache_dir, cddb_data->disc_id);
> >>
> >>  	file_fd = open(file_name, O_RDONLY
> >>-#if defined(__MINGW32__) || defined(__CYGWIN__)
> >>+#if defined(__MINGW32__) || defined(__CYGWIN__) || defined(__OS2__)
> >>  	| O_BINARY
> >>  #endif
> >
> >This looks like a candidate for a configure check.
> 
> So do I. I'll try later such as HAVE_DOS_BINARY ? Hmm.. poor nameing sense.

#ifndef O_BINARY
#define O_BINARY 0
#endif
for example.
Don't see why this should depend on the OS instead of whether O_BINARY exists.
No other comments from me.