[MPlayer-dev-eng] [PATCH] CDDB support for OS/2

[KO Myung-Hun]

Diego Biurrun wrote:
> On Fri, Feb 19, 2010 at 12:24:20PM +0900, KO Myung-Hun wrote:
>>
>> This patch adds CDDB support for OS/2.
>>
>> --- stream/stream_cddb.c	(revision 30605)
>> +++ stream/stream_cddb.c	(working copy)
>> @@ -66,6 +66,10 @@
>>           #include<IOKit/storage/IOCDTypes.h>
>>           #include<IOKit/storage/IOCDMediaBSDClient.h>
>>   	#include "mpbswap.h"
>> +#elif defined(__OS2__)
>> +#define INCL_DOS
>> +#define INCL_DOSDEVIOCTL
>> +#include<os2.h>
>>   #endif
>
> Once again, this looks awfully familiar..
>

So do I. T.T

>> @@ -108,6 +112,85 @@
>>
>> +    if (rc) {
>> +        mp_msg(MSGT_OPEN, MSGL_ERR, MSGTR_MPDEMUX_CDDB_FailedToReadTOC);
>> +
>> +        return -1;
>> +    }
>
> I'd drop the empty line.
>

Fixed.

>> +        for (i = first; i<= last; i++) {
>> +            if (i == last) {
>> +                sDataTrack.bStartM = sDataDisk.bLeadOutM;
>> +                sDataTrack.bStartS = sDataDisk.bLeadOutS;
>> +                sDataTrack.bStartF = sDataDisk.bLeadOutF;
>> +            }
>> +            else {
>
> } else {
>

Fixed.

>> @@ -340,7 +423,7 @@
>>   	sprintf( file_name, "%s%08lx", cddb_data->cache_dir, cddb_data->disc_id);
>>
>>   	file_fd = open(file_name, O_RDONLY
>> -#if defined(__MINGW32__) || defined(__CYGWIN__)
>> +#if defined(__MINGW32__) || defined(__CYGWIN__) || defined(__OS2__)
>>   	| O_BINARY
>>   #endif
>
> This looks like a candidate for a configure check.

So do I. I'll try later such as HAVE_DOS_BINARY ? Hmm.. poor nameing sense.

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 2.0
Under OS/2 Warp 4 for Korean with FixPak #15
On Intel Core2Duo T5500 1.66 GHz with 1 GB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: cddbos2.diff
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20100219/80ff23e9/attachment.asc>