[MPlayer-dev-eng] [ass] fix font aspect for anamorphic video

[Reimar Döffinger]

On Tue, Feb 09, 2010 at 06:36:04PM +0100, Grigori Goronzy wrote:
> On 02/09/2010 05:34 PM, Reimar Döffinger wrote:
> > The first one allows building against old fontconfig.
> > That's mostly because there still seem to be people around with
> > the old version, and losing support for embedded fonts just seems
> > not that critical to me.
> 
> In my opinion people should simply update fontconfig. The minimum
> version required, 2.4.2, is over three years old and even severly
> outdated and now unsupported Debian oldstable does have the required
> version.

Fine by me in principle, it just seemed trivial

> The documentation should be updated of course, noted.

Main reason why I bothered at all - and not knowing how old fontconfig
2.4.2 is.

> IIRC MPlayer does
> not check fontconfig version, maybe that should be changed.

Since you don't like the fallback solution yes.

> > For the second one, my understanding is that recalculating render_priv->font_scale
> > is pointless if you don't also reconfigure.
> > At least it fixes MPlayer's strange behaviour that you get different font sizes
> > depending on whether you first load the subtitle and then set the font size
> > or the other way round.
> 
> Sorry, I don't really understand. The functions to set font scale and
> aspect ratio already call reconfigure if something changes, there should
> be no need to do this again later.

Let me try to give my reasoning that does not need any bug:
If render_priv->font_scale is only changed by those functions, why isn't
it calculated in those (or in ass_reconfigure)?
If it can change, don't you have to call ass_reconfigure?
That said, my way to check will cause ass_reconfigure to be called all the time,
which is a bad idea so I'll have to debug a bit further anyway.