[MPlayer-dev-eng] [PATCH] enumpins interface leak in DS_Filter.c may cause binary codec crash at exit

[Gianluigi Tiesi]

On Tue, Feb 02, 2010 at 08:06:19PM +0100, Reimar D?ffinger wrote:
> On Tue, Feb 02, 2010 at 12:12:48AM +0100, Gianluigi Tiesi wrote:
> > while playing with coreavc patches I've noticed that the binary codec is not
> > released correctly, the smartpointer of the codec does not reach refcount 0
> > 
> > so e.g. coreavc tries to do something with windproc used for tray icon
> > 
> > the attached patch fixes it by releasing unreleased enum_pins interface
> 
> Is there some reason why you can't release it immediately after calling "Next"
> on it? That seems to be the last use of it and would keep things a tiny bit
> better together.

yes you are correct, I was using Next() with 1 element at time in my stuff
so I need the interface for the whole loop.
in DS_Filter code, the interface can be released after Next()

Regards

-- 
Gianluigi Tiesi <sherpya at netfarm.it>
EDP Project Leader
Netfarm S.r.l. - http://www.netfarm.it/
Free Software: http://oss.netfarm.it/