[MPlayer-dev-eng] [PATCH] enumpins interface leak in DS_Filter.c may cause binary codec crash at exit

Reimar Döffinger Reimar.Doeffinger at gmx.de
Tue Feb 2 20:06:19 CET 2010


On Tue, Feb 02, 2010 at 12:12:48AM +0100, Gianluigi Tiesi wrote:
> while playing with coreavc patches I've noticed that the binary codec is not
> released correctly, the smartpointer of the codec does not reach refcount 0
> 
> so e.g. coreavc tries to do something with windproc used for tray icon
> 
> the attached patch fixes it by releasing unreleased enum_pins interface

Is there some reason why you can't release it immediately after calling "Next"
on it? That seems to be the last use of it and would keep things a tiny bit
better together.
Apart from that it seems obviously right (volunteers to test it more thoroughly
with more codecs would still as always be very welcome :-) ).



More information about the MPlayer-dev-eng mailing list