[MPlayer-dev-eng] [PATCH] Correct translation of filename

Ingo Brueckl ib at wupperonline.de
Tue Dec 21 23:57:34 CET 2010

Reimar Döffinger wrote on Tue, 21 Dec 2010 09:10:57 and 09:26:23 +0100:

> The idea of the code is to only cut 3 or 4 letter extensions, your
> change would e.g. cut This.IsSomething to This.

Yeah, but what about files like something.au, something.ra or (possibly?)
5 letter extensions?

I don't mind the current approach either, but as you noticed ...

> I have to note that the current code does not correctly check the
> length and for short strings will access outside the array,

... there has to be a length check. (Alternative patch attached.)

> we have been suggesting to everyone to use smplayer.

The problem with the GUIs mentioned on the web page is their depedencies.
I'm currently using vlc and want to get rid of Qt (which is only installed
for vlc). There is no small and simple but sufficient GUI which only needs
gtk and nothing else - besides gmplayer, and I like it for that reason.

> On the other hand you seem quite motivated, if you are genuinly
> interested in improving the mess that the Gui code is,

Yes, I'd like to fix a few things in it. For example, the fullscreen
options reacts strangely and I'd like an option to quit it after playing.
So there are patches to come.

> I'd be in favour of giving you commit access and relatively free reign over
> everything in gui/. If that suits you, read DOCS/tech/svn-howto.txt and ask
> Diego for username/password (since we might soonish switch to git

It would, but I'd like to wait until git access is available, because I'm
using git (public key available) and haven't used svn so far.

(BTW, how will be the ok-to-commit procedure then?)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: gmplayer.translate.filename.patch
Type: application/octet-stream
Size: 1071 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20101221/6e68d997/attachment.obj>

More information about the MPlayer-dev-eng mailing list