[MPlayer-dev-eng] [PATCH] proper version info for git.mplayerhq.hu
divVerent at alientrap.org
Wed Dec 15 19:44:29 CET 2010
On Wed, Dec 15, 2010 at 04:51:50PM +0100, Diego Biurrun wrote:
> On Wed, Dec 15, 2010 at 03:18:29PM +0100, Clément Bœsch wrote:
> > On Wed, Dec 15, 2010 at 03:14:43PM +0100, Diego Biurrun wrote:
> > > On Thu, Dec 09, 2010 at 07:30:59AM +0100, Rudolf Polzer wrote:
> > > >
> > > > Then the attached one should be better.
> > >
> > > Use 4 spaces for indentation, put a space after '>' and replace `` with $().
> > Why $() is prefered over ``?
> $() is no less portable in practice and saner to nest.
I do remember once having used a system where `` worked and $() did not. But I
doubt these systems run mplayer anyway.
> > > I need to have a closer look later, but I do wonder why this is so much
> > > code...
> > I agree that could be simplified with a simple git describe just like it
> > seems to be with FFmpeg.
> That's why I was wondering. I hadn't looked at FFmpeg's implementation
> again, but I faintly remember it being much simpler.
git describe won't tell the svn revision the git repo bases it on. "Initialtag
+ revision count" doesn't necessarily match up with the svn revision. To use
git describe, we should also regularily make "version tags" and such.
More information about the MPlayer-dev-eng