[MPlayer-dev-eng] [PATCH] proper version info for git.mplayerhq.hu
diego at biurrun.de
Wed Dec 15 16:51:50 CET 2010
On Wed, Dec 15, 2010 at 03:18:29PM +0100, Clément Bœsch wrote:
> On Wed, Dec 15, 2010 at 03:14:43PM +0100, Diego Biurrun wrote:
> > On Thu, Dec 09, 2010 at 07:30:59AM +0100, Rudolf Polzer wrote:
> > >
> > > Then the attached one should be better.
> > Use 4 spaces for indentation, put a space after '>' and replace `` with $().
> Why $() is prefered over ``?
$() is no less portable in practice and saner to nest.
> Just to be consistent with the rest of the script?
That's another reason.
> > I need to have a closer look later, but I do wonder why this is so much
> > code...
> I agree that could be simplified with a simple git describe just like it
> seems to be with FFmpeg.
That's why I was wondering. I hadn't looked at FFmpeg's implementation
again, but I faintly remember it being much simpler.
More information about the MPlayer-dev-eng