[MPlayer-dev-eng] [PATCH] unified timing patch for H264

[Pásztor Szilárd]

Reimar Döffinger:
> > Ok, so here is the "correct" deal, at least I hope so.
> > This time both parts (with correct-pts and without) are
> > changed. The information about we having a displayable
> > frame or not now gets propagated up to both decoding
> > parts right from the h264 parser, without touching
> > anything else.
> 
> Huh? Are you sure about that?

? Do you see anything that would be affected? I don't...

> > -    if (correct_pts && pts != MP_NOPTS_VALUE) {
> > +    mpi = mpvdec->decode(sh_video, start, in_size, drop_frame);
> > +    if (mpi && mpi->type == MP_IMGTYPE_NULL) {
> 
> Well, I guess it is possible this somehow happens
> to be the right thing to check (though I have some
> doubts) but even then that's unintentional
> and might break at any time.
> How did you come up with the idea of using that?

Could you explain in more detail what you are referring to?
This is intentionally "the right thing" to check because I purposely added
this image type and it won't break until someone breaks it.

s.

               --------------------------------------------------
               |   If you never try anything new, you'll miss   |
               |  out on many of life's great disappointments.  |
               --------------------------------------------------