[MPlayer-dev-eng] [PATCH] unified timing patch for H264

[Reimar Döffinger]

On Thu, Aug 19, 2010 at 04:06:28AM +0200, Pásztor Szilárd wrote:
> Ok, so here is the "correct" deal, at least I hope so.
> This time both parts (with correct-pts and without) are
> changed. The information about we having a displayable
> frame or not now gets propagated up to both decoding
> parts right from the h264 parser, without touching
> anything else.

Huh? Are you sure about that?

> -    if (correct_pts && pts != MP_NOPTS_VALUE) {
> +    mpi = mpvdec->decode(sh_video, start, in_size, drop_frame);
> +    if (mpi && mpi->type == MP_IMGTYPE_NULL) {

Well, I guess it is possible this somehow happens
to be the right thing to check (though I have some
doubts) but even then that's unintentional
and might break at any time.
How did you come up with the idea of using that?