[MPlayer-dev-eng] [PATCH] EOSD/ASS code factorization

Reimar Döffinger Reimar.Doeffinger at gmx.de
Tue Aug 17 19:47:42 CEST 2010


On Sat, Aug 14, 2010 at 10:15:50PM +0200, Nicolas George wrote:
> +int prev_visibility = 0;

The = 0 part is pointless.

>  static void uninit(struct vf_instance *vf)
>  {
> -    if (vf->priv) {
> -#ifdef CONFIG_ASS
> -        if (vf->priv->ass_priv)
> -            ass_renderer_done(vf->priv->ass_priv);
> -#endif
> +    if (vf->priv)
>          free(vf->priv);

You can then remove the if as well while at it, free(NULL) is okay.

Please read DOCS/tech/svn-howto.txt and if you're ok with it
(in particular the policy) then please email your desired username
and password GPG-encrypted to Diego and commit this yourself.


More information about the MPlayer-dev-eng mailing list