[MPlayer-dev-eng] [PATCH] EOSD/ASS code factorization

Nicolas George nicolas.george at normalesup.org
Tue Aug 17 16:53:56 CEST 2010


Le nonidi 29 thermidor, an CCXVIII, Reimar Döffinger a écrit :
> Haven't reviewed it, but it also accepts octal.
> So 010 becomes 8, I am not sure that is what you want.

I know. Is it really a problem? The C syntax for octal is stupid (0o would
have been much smarter), but it is rarely problematic, and octal is
occasionally useful. If it is a blocking problem, I can re-submit with
"ptr[0] == '0' && (ptr[1] | 0x20) != 'x' ? 10 : 0" as the base argument to
accept 0x but not 0.

Anyway, this patch is just a small thing while I was looking at the code.
The interesting ones are the two others.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20100817/ecb3feaf/attachment.pgp>


More information about the MPlayer-dev-eng mailing list