[MPlayer-dev-eng] [PATCH] EOSD/ASS code factorization

[Nicolas George]

Le septidi 27 thermidor, an CCXVIII, Reimar Döffinger a écrit :
> I think this is really bad readability-wise.

I agree. I hesitated, but I thought it matched the surrounding coding style
more closely.

> An actual separate variable may be a bit better, but I tend toward
> suggesting to just have individual arguments.

Individual arguments would require to unpack the structure for the similar
call in vf_vo. I went for a separate variable, it is much more readable now.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayer-eosd-factor-20100814b.diff
Type: text/x-diff
Size: 10946 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20100814/014df99c/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20100814/014df99c/attachment.pgp>