[MPlayer-dev-eng] [PATCH] EOSD/ASS code factorization

Reimar Döffinger Reimar.Doeffinger at gmx.de
Sat Aug 14 12:13:01 CEST 2010


On Sat, Aug 14, 2010 at 11:50:26AM +0200, Nicolas George wrote:
> +	eosd_configure(&(mp_eosd_res_t){ .w = vf->priv->outw, .h = vf->priv->outh,
> +		.srcw = width, .srch = height,
> +		.mt = ass_top_margin, .mb = ass_bottom_margin, .ml = 0, .mr = 0 }, 0);

I think this is really bad readability-wise.
An actual separate variable may be a bit better, but I tend toward
suggesting to just have individual arguments.


More information about the MPlayer-dev-eng mailing list