[MPlayer-dev-eng] mplayer on kfreebsd

Diego Biurrun diego at biurrun.de
Fri Apr 23 02:47:27 CEST 2010


On Thu, Apr 22, 2010 at 09:50:42PM +0200, Reinhard Tartler wrote:
> 
> while testing diego's patches for http://bugs.debian.org/578622, I've
> noticed that this alone is not enough to get mplayer built on
> kFreebsd/amd64. The first patch should be pretty much a no-brainer:
> 
> --- libvo/vo_directfb2.c	(revision 31057)
> +++ libvo/vo_directfb2.c	(working copy)
> @@ -34,7 +34,7 @@
>  
> -#ifdef __linux__
> +#ifndef __linux__
>  #include <sys/kd.h>
>  #else
>  #include <linux/kd.h>

This one is obvious, but please switch the #includes instead in order
to avoid inverse logic.

> The other thing I've noticed is that kfreebsd already defines a 'struct
> keymap'. I therefore propose to rename the to 'struct m_keymap'

mp_keymap, OK otherwise

Diego



More information about the MPlayer-dev-eng mailing list