[MPlayer-dev-eng] [PATCH] new option: -startpos (was "the seek to position -ss option does not really set a new playback start position")
jehan.marmottard at gmail.com
Sat Apr 17 06:05:51 CEST 2010
ok so I will put it exactly as it was. Before making a new patch,
could you tell me if it is ok like this, regarding the previous
comment I got from Uoti?
On Mon, Apr 12, 2010 at 1:39 PM, RC <cooleyr at gmail.com> wrote:
> On Thu, 8 Apr 2010 11:57:25 +0900
> Jehan Pagès <jehan.marmottard at gmail.com> wrote:
>> > Please remove this cosmetic hunk from the patch.
>> Note that this was there before my patch. I just change its place as I
>> modified around here
> Yes, that's what "cosmetic" means...
> Patches that change indenting, and the like (cosmetics), are to be
> seperated from functional changes (seperate patch), so they can be
> reviewed more easily. This is in the MPlayer documentation.
> Ha. I'm the idiot.
> MPlayer-dev-eng mailing list
> MPlayer-dev-eng at mplayerhq.hu
More information about the MPlayer-dev-eng