[MPlayer-dev-eng] [PATCH] new option: -startpos (was "the seek to position -ss option does not really set a new playback start position")
RC
cooleyr at gmail.com
Mon Apr 12 06:39:32 CEST 2010
On Thu, 8 Apr 2010 11:57:25 +0900
Jehan Pagès <jehan.marmottard at gmail.com> wrote:
> > Please remove this cosmetic hunk from the patch.
>
> Note that this was there before my patch. I just change its place as I
> modified around here
Yes, that's what "cosmetic" means...
Patches that change indenting, and the like (cosmetics), are to be
seperated from functional changes (seperate patch), so they can be
reviewed more easily. This is in the MPlayer documentation.
--
Ha. I'm the idiot.
More information about the MPlayer-dev-eng
mailing list