[MPlayer-dev-eng] [PATCH] VDPAU: add BT.709 support

[Reimar Döffinger]

On Sat, Oct 10, 2009 at 03:36:24PM +0000, Carl Eugen Hoyos wrote:
> Lauri Mylläri <lauri.myllari <at> gmail.com> writes:
> 
> > +    static const VdpColorStandard vdp_colors[] = {0,
> > VDP_COLOR_STANDARD_ITUR_BT_601, VDP_COLOR_STANDARD_ITUR_BT_709};
> > +    static const char * const vdp_names[] = {NULL, "BT.601", "BT.709"};
> > +    int csp = colorspace;
> > +
> > +    if (!csp)
> > +        csp = vid_width >= 1280 || vid_height > 576 ? 2 : 1;
> 
> Could you repeat why this is useful/correct/needed?

That's what several graphics drivers do, it is just guessing but some
people might actually like it (with original data it probably is mostly
correct).

> If it is generally agreed on, 0 should probably be made default.

It is unreliable. I am against making some unreliable guessing the
default, it just makes debugging harder (there are lots of
threads/confusion/complaints about this kind of auto-detection on
Windows, and ffdshow instead lets you specify even a formula to base the
autodetection on, so obviously this is not really possible to get 100%
right).