[MPlayer-dev-eng] [PATCH] VDPAU: add BT.709 support

Carl Eugen Hoyos cehoyos at ag.or.at
Sat Oct 10 17:36:24 CEST 2009


Lauri Mylläri <lauri.myllari <at> gmail.com> writes:

> +    static const VdpColorStandard vdp_colors[] = {0,
> VDP_COLOR_STANDARD_ITUR_BT_601, VDP_COLOR_STANDARD_ITUR_BT_709};
> +    static const char * const vdp_names[] = {NULL, "BT.601", "BT.709"};
> +    int csp = colorspace;
> +
> +    if (!csp)
> +        csp = vid_width >= 1280 || vid_height > 576 ? 2 : 1;

Could you repeat why this is useful/correct/needed?
If it is generally agreed on, 0 should probably be made default. (My original
suggestion meant a patch that only accepted 1 or 2 and has 601 the default, so
that 0 could be added later.)
I can't comment, also because I don't see any difference on my FW900. (Is a Flat
Screen necessary to see a difference?)

If Reimar has no more comments, I will apply the patch.

Carl Eugen




More information about the MPlayer-dev-eng mailing list