[MPlayer-dev-eng] [PATCH v2] Mac OS X: fix compilation on Mac OS X 10.4

Adrian Stutz adrian at sttz.ch
Tue Oct 6 10:29:07 CEST 2009


On Tue, Oct 6, 2009 at 9:23 AM, Aaro Koskinen <aaro.koskinen at iki.fi> wrote:
>>> +#if defined(MAC_OS_X_VERSION_MAX_ALLOWED)
>>> +#if MAC_OS_X_VERSION_MAX_ALLOWED <= 1040
>>
>> These two look redundant.
>
> On later SDKs the definition is either missing, or defaults to > 1040.
> I cannot verify this as the latest Mac OS X cannot be installed on any
> of my computers.

The definition is present in all new SDKs, including 10.6.

In my test, MAC_OS_X_VERSION_MAX_ALLOWED is always defined, unless
compiling for non-desktop OSX like the iPhone OS. Therefore a single
check like "MAC_OS_X_VERSION_MAX_ALLOWED <= 1040" should be
sufficient.

Modified patch applied.

Greetings
Adrian



More information about the MPlayer-dev-eng mailing list