[MPlayer-dev-eng] [PATCH][TRIVIAL] Few cosmetics to x11_common

[Reimar Döffinger]

On Tue, Nov 03, 2009 at 09:42:17AM -0300, Reynaldo H. Verdejo Pinochet wrote:
> Hello
> 
> Reimar Döffinger wrote:
> > On Tue, Nov 03, 2009 at 01:04:45AM -0300, Reynaldo H. Verdejo Pinochet wrote:
> >> @@ -1123,9 +1121,9 @@
> >>      XMapWindow(mDisplay, vo_window);
> >>      XClearWindow(mDisplay, vo_window);
> >>      // wait for map
> >> -    do {
> >> +    do
> >>        XNextEvent(mDisplay, &xev);
> >> -    } while (xev.type != MapNotify || xev.xmap.event != vo_window);
> >> +    while (xev.type != MapNotify || xev.xmap.event != vo_window);
> > 
> > It definitely should be tested.
> 
> Tested it already.

Hmm... Amazing. I somehow assumed do/while needs {}. Either way, there
is not really much of an advantage of removing them here.

> > Some of the linebreak changes (particularly the strargcmp stuff) is a 
> > bit questionable, you could say it decreases readability, same for
> > the {} for nested loops.
> 
> Sure. Make it to suit your taste. I'm attaching
> a tad-beyond-cosmetical change that was amongst
> those toh.

That one is of course fine, as well as quite a few other
changes.