[MPlayer-dev-eng] [PATCH][TRIVIAL] Few cosmetics to x11_common

Reynaldo H. Verdejo Pinochet reynaldo at opendot.cl
Tue Nov 3 13:42:17 CET 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello

Reimar Döffinger wrote:
> On Tue, Nov 03, 2009 at 01:04:45AM -0300, Reynaldo H. Verdejo Pinochet wrote:
>> @@ -1123,9 +1121,9 @@
>>      XMapWindow(mDisplay, vo_window);
>>      XClearWindow(mDisplay, vo_window);
>>      // wait for map
>> -    do {
>> +    do
>>        XNextEvent(mDisplay, &xev);
>> -    } while (xev.type != MapNotify || xev.xmap.event != vo_window);
>> +    while (xev.type != MapNotify || xev.xmap.event != vo_window);
> 
> It definitely should be tested.

Tested it already.

> Some of the linebreak changes (particularly the strargcmp stuff) is a 
> bit questionable, you could say it decreases readability, same for
> the {} for nested loops.

Sure. Make it to suit your taste. I'm attaching
a tad-beyond-cosmetical change that was amongst
those toh.

Bests

- --
Reynaldo
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAkrwJSgACgkQwY4HfzEURSrvhQCcDeAgTHK4bg9WyJmtm2fXAWzY
t1oAn0oNF9UJ7X+aHfCjttYMS48o6YdG
=wmRi
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 20091103_useless_initialization.diff
Type: text/x-patch
Size: 308 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20091103/1b577714/attachment.bin>


More information about the MPlayer-dev-eng mailing list