[MPlayer-dev-eng] [PATCH] vo_macosx: fix screen init and unify error message

[Adrian Stutz]

On Thu, Feb 26, 2009 at 9:08 PM, Ergzay <ergzay at gmail.com> wrote:

> I know I'm resurrecting an over a month old post but I thought I
> should say something.
>
> While the current functionality is good with letting the user select
> the forced full screen, what should not be done is have the UI
> complain to the user that there is an error when there is not (if I am
> understanding this correctly). As currently with no device_id set,
> every time you run mplayer you get a "Get device error: Device ID -1
> do not exist, falling back to main device." This is not really an
> error, correct? A default setting shouldn't be an error setting.
> Shouldn't we instead remove said error (or change how it appears) or
> default the device ID to 0 (current display)?


Here are two patches:

- The first one fixes the if that compared an int with an unsigned int and
triggered the error to be printed even if it shouldn't with screen_id == -1.

- The second one unifies all error messages in vo_macosx to make clear where
they originate from.
I'm not sure what the preferred format would be. I chose [vo_macosx] because
[name] seems to be used most and [macosx] is ambiguous.

Greetings
Adrian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vo_macosx_screen_init_fix.patch
Type: application/octet-stream
Size: 416 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20090308/1a8a1fd7/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vo_macosx_unify_error_output.patch
Type: application/octet-stream
Size: 4227 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20090308/1a8a1fd7/attachment-0001.obj>