[MPlayer-dev-eng] [PATCH] disable libdv by default

Reimar Döffinger Reimar.Doeffinger at gmx.de
Sat Mar 7 15:40:13 CET 2009


Hello,
libdv has a rather unreliable auto-detection and I think that
libavformat/libavcodec in general work better for it (if not we will get
some bug reports).
Thus I propose disabling libdv unless explicitly disabled. I admit that
having libdv installed is reason to suggest the user wants it to be
used, but in case of libdv I think there are simply other programs that
indeed need it whereas for MPlayer it mostly causes issues.

Greetings,
Reimar Döffinger
-------------- next part --------------
Index: configure
===================================================================
--- configure	(revision 28869)
+++ configure	(working copy)
@@ -326,7 +326,7 @@
   --disable-faac            disable support for FAAC (AAC encoder) [autodetect]
   --disable-faac-lavc       disable support for FAAC in libavcodec [autodetect]
   --disable-ladspa          disable LADSPA plugin support [autodetect]
-  --disable-libdv           disable libdv 0.9.5 en/decoding support [autodetect]
+  --enable-libdv            enable libdv 0.9.5 en/decoding support [disabled]
   --disable-mad             disable libmad (MPEG audio) support [autodetect]
   --disable-mp3lame         disable LAME MP3 encoding support [autodetect]
   --disable-mp3lame-lavc    disable LAME in libavcodec [autodetect]
@@ -693,7 +693,7 @@
 _dynamic_plugins=no
 _crash_debug=no
 _sighandler=yes
-_libdv=auto
+_libdv=no
 _cdparanoia=auto
 _cddb=auto
 _big_endian=auto
@@ -6979,14 +6979,6 @@
 echores "$_libamr_wb"
 
 echocheck "libdv-0.9.5+"
-if test "$_libdv" = auto ; then
-  _libdv=no
-  cat > $TMPC <<EOF
-#include <libdv/dv.h>
-int main(void) { dv_encoder_t* enc=dv_encoder_new(1,1,1); return 0; }
-EOF
-  cc_check -ldv $_ld_pthread $_ld_lm && _libdv=yes
-fi
 if test "$_libdv" = yes ; then
   def_libdv='#define CONFIG_LIBDV095 1'
   _ld_extra="$_ld_extra -ldv"


More information about the MPlayer-dev-eng mailing list