[MPlayer-dev-eng] [PATCH] single-frame offset in EOSD drawing

Grigori Goronzy greg at chown.ath.cx
Fri Mar 6 11:17:24 CET 2009


Reimar Döffinger wrote:
> 
> If that is right depends on why it is in that order. If the reason is
> that the EOSD is supposed to be drawn _above_ the OSD, the current code
> in the vos is wrong, if the EOSD is supposed to be below the OSD, this
> code here is nonsense and would make it unnecessarily hard to implement
> ASS support in a vo that renders directly instead of making an extra
> copy of the images as vo_gl/vo_vdpau do.

In my opinion, EOSD should be drawn below OSD, but that's probably a
matter of preference...

The *real* problem is that within the drivers that natively support
EOSD, gl and vdpau, currently EOSD isn't drawn with the VFCTRL_DRAW_EOSD
call, but along with the OSD with the VFCTRL_DRAW_OSD call.

Grigori



More information about the MPlayer-dev-eng mailing list