[MPlayer-dev-eng] [PATCH] single-frame offset in EOSD drawing

[Reimar Döffinger]

On Fri, Mar 06, 2009 at 11:17:24AM +0100, Grigori Goronzy wrote:
> Reimar Döffinger wrote:
> > If that is right depends on why it is in that order. If the reason is
> > that the EOSD is supposed to be drawn _above_ the OSD, the current code
> > in the vos is wrong, if the EOSD is supposed to be below the OSD, this
> > code here is nonsense and would make it unnecessarily hard to implement
> > ASS support in a vo that renders directly instead of making an extra
> > copy of the images as vo_gl/vo_vdpau do.
> 
> In my opinion, EOSD should be drawn below OSD, but that's probably a
> matter of preference...

Then it makes sense to change it.

> The *real* problem is that within the drivers that natively support
> EOSD, gl and vdpau, currently EOSD isn't drawn with the VFCTRL_DRAW_EOSD
> call, but along with the OSD with the VFCTRL_DRAW_OSD call.

Well, for vdpau it is a non-issue to change it. For vo_gl it means a bit
of code duplication/extra code, but it is not hard either...