[MPlayer-dev-eng] [PATCH] vo_kva

[Diego Biurrun]

On Sun, Mar 01, 2009 at 10:04:21PM +0900, KO Myung-Hun wrote:
>
> Diego Biurrun wrote:
>> On Sun, Mar 01, 2009 at 08:19:35PM +0900, KO Myung-Hun wrote:
>>   
>>> KO Myung-Hun wrote:
>>>     
>>> --- DOCS/man/en/mplayer.1	(revision 28767)
>>> +++ DOCS/man/en/mplayer.1	(working copy)
>>> @@ -3573,6 +3585,22 @@
>>>  .
>>> +.IPs (no)t23
>>> +Enable/disable workaround for T23 laptop (default: \-not23).
>>
>> ?
>
> Added more detailed explanation.
>
> --- libvo/vo_kva.c	(revision 0)
> +++ libvo/vo_kva.c	(revision 0)
> @@ -0,0 +1,1193 @@
> +static void imgDisplay(void)
> +{
> +    PVOID       pBuffer;
> +    ULONG       ulBPL;

Any particular reason to use so many spaces?  Not that it matters..

> +#define MRETURN(ret)  return (MRESULT)(ret)

This just looks like obfuscation to me.

> +    WinRegisterClass(
> +        m_int.hab,
> +        WC_MPLAYER,
> +        WndProc,
> +        CS_SIZEREDRAW | CS_MOVENOTIFY,
> +        sizeof(PVOID)
> +   );

That's a weird way to format the function.  Please be consistent with
the rest.

> +static void check_events(void)
> +{
> +}
> +
> +

nit: stray empty lines

> --- DOCS/man/en/mplayer.1	(revision 28767)
> +++ DOCS/man/en/mplayer.1	(working copy)
> @@ -3573,6 +3585,23 @@
> +.IPs (no)t23
> +Enable/disable workaround for T23 laptop (default: \-not23).
> +Try to enable this option, if your video card supports up-scaling only.

Upscaling, leave out the comma.

Diego