[MPlayer-dev-eng] [PATCH] vo_kva

[KO Myung-Hun]

Hi/2.

Diego Biurrun wrote:
> On Sun, Mar 01, 2009 at 08:19:35PM +0900, KO Myung-Hun wrote:
>   
>> KO Myung-Hun wrote:
>>     
>>> Diego Biurrun wrote:
>>>   
>>>       
>>>> On Thu, Feb 26, 2009 at 12:00:23AM +0900, KO Myung-Hun wrote:
>>>>       
>>>>         
>>>>> This patch adds a vo_kva for OS/2 video system.
>>>>>
>>>>> --- libvo/vo_kva.c	(revision 0)
>>>>> +++ libvo/vo_kva.c	(revision 0)
>>>>> @@ -0,0 +1,1194 @@
>>>>> +            //if (ustflags & (TF_LEFT | TF_RIGHT | TF_TOP | TF_BOTTOM | TF_SETPOINTERPOS))
>>>>> +            {
>>>>> +            #if 0
>>>>> +                pti->rclBoundary.xLeft   = 0;
>>>>> +                pti->rclBoundary.yBottom = 0;
>>>>> +                pti->rclBoundary.xRight  = vo_screenwidth;
>>>>> +                pti->rclBoundary.yTop    = vo_screenheight;
>>>>> +            #endif
>>>>>           
>>>>>           
>>>> What is this disabled code good for?  If it's good for nothing, get rid
>>>> of it.
>>>>         
>>> It is for tracking boundary. If it's set, movie window does not go out  
>>> of screen. If possible, I want to preserve it. If needed, I'll add  
>>> comments for it.
>>>       
>
> At least add a comment.  But I disagree that it should be preserved.
> If you intend to add functionality based on it, add that hunk along
> with the patch that implements the functionality.  Right now it's just
> cruft and should be left out.
>
>   

Ok.

>> I attach the updated patch.
>>
>> --- libvo/vo_kva.c	(revision 0)
>> +++ libvo/vo_kva.c	(revision 0)
>> @@ -0,0 +1,1202 @@
>> +    switch (m_int.iImageFormat) {
>> +        case IMGFMT_YV12 :
>> +            size += size / 2;
>> +            n = 2;
>> +            break;
>>     
>
> K&R places the case at the same depth as the switch.
>
>   

Fixed.

>> --- configure	(revision 28767)
>> +++ configure	(working copy)
>> @@ -5091,6 +5099,30 @@
>>
>> +  _vosrc="$_vosrc vo_kva.c"
>>     
>
> _vosrc is long gone.
>
>   

Ok.

>> --- DOCS/man/en/mplayer.1	(revision 28767)
>> +++ DOCS/man/en/mplayer.1	(working copy)
>> @@ -3573,6 +3585,22 @@
>>  .
>> +.IPs (no)t23
>> +Enable/disable workaround for T23 laptop (default: \-not23).
>>     
>
> ?
>
>   

Added more detailed explanation.


-- 
KO Myung-Hun

Using Mozilla SeaMonkey 1.1.14
Under OS/2 Warp 4 for Korean with FixPak #15
On AMD ThunderBird 1 GHz with 512 MB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr


-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: kva.diff
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20090301/3f05af34/attachment.txt>