[MPlayer-dev-eng] [PATCH] -geometry support in vo_fbdev2

[Benson Mitchell]

On 6/27/09, Reimar Döffinger <Reimar.Doeffinger at gmx.de> wrote:
> On Sat, Jun 27, 2009 at 04:33:06AM -0400, Benson Mitchell wrote:
>> Well, I guess it's all correct now.
>
> Good enough. Strictly speaking it still has issues if the video is larger
> than the display resolution, but that IMO is an independent issue.
Yeah, that goes back to its 1:1 display, which also does stupid things
with my rectangular-pixel video files. I think it should insert a
scale filter or something, but I looked at that and chickened out.
Anyway, it does bail from config in that case, instead of clobbering
video ram past the fb, so at least it's safe.

> Please use av_clip from libavutil/common.h for clipping the vo_dx/vo_dy
> values though, it should be a good bit more readable.
Done.

>> If this looks OK, I'll probably do the same work on vo_fbdev.c
>> tomorrow sometime,
>
> It might not be worth it, vo_fbdev supports resolution switching, and
> in that case you have to recalculate everything anyway, implementing
> VOCTRL_UPDATE_SCREENINFO alone won't help much.
> Unless you are interested in doing more work and adding a function that
> recalculates everything after a video mode switch.
Meh, that begins to sound like work. Think I'll let it go.