[MPlayer-dev-eng] [PATCH] -geometry support in vo_fbdev2

Reimar Döffinger Reimar.Doeffinger at gmx.de
Sat Jun 27 10:43:42 CEST 2009


On Sat, Jun 27, 2009 at 04:33:06AM -0400, Benson Mitchell wrote:
> Well, I guess it's all correct now.

Good enough. Strictly speaking it still has issues if the video is larger
than the display resolution, but that IMO is an independent issue.
Please use av_clip from libavutil/common.h for clipping the vo_dx/vo_dy
values though, it should be a good bit more readable.

> If this looks OK, I'll probably do the same work on vo_fbdev.c
> tomorrow sometime,

It might not be worth it, vo_fbdev supports resolution switching, and
in that case you have to recalculate everything anyway, implementing
VOCTRL_UPDATE_SCREENINFO alone won't help much.
Unless you are interested in doing more work and adding a function that
recalculates everything after a video mode switch.



More information about the MPlayer-dev-eng mailing list