[MPlayer-dev-eng] [PATCH] Print chapter info with -identify

Adrian Stutz adrian at sttz.ch
Sun Jun 28 14:44:28 CEST 2009


On Sun, Jun 28, 2009 at 10:11 AM, Reimar
Döffinger<Reimar.Doeffinger at gmx.de> wrote:
> The reason why I dislike it is that it adds extra code to do it, is a
> bit inconsistent with what is common for aid/vid/sid, and in your
> particular case also adds a bug, the return value of add_chapter is now
> one too large.

Oh, my bad, I was too eager to cut patch size at the last moment.

> I won't really insist, I just have the feeling that the 1-based
> numbering (at least unless done in a more flexible/whatever way)
> is going to be a bit of a maintenance issue.

You just did. ;)

Attached are updated patches, one to print zero-based chapter info
with -identify and one to update the slave mode to set chapters
zero-based.

Greetings
Adrian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: identify_print_chapters.patch
Type: text/x-diff
Size: 813 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20090628/c4a28405/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: set_chapter_property_zero_based.patch
Type: text/x-diff
Size: 789 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20090628/c4a28405/attachment-0001.patch>


More information about the MPlayer-dev-eng mailing list