[MPlayer-dev-eng] [PATCH] -geometry support in vo_fbdev2

[Reimar Döffinger]

On Fri, Jun 26, 2009 at 09:05:06AM -0400, Benson Mitchell wrote:
> On Fri, Jun 26, 2009 at 7:29 AM, Reimar Döffinger
> <Reimar.Doeffinger at gmx.de>wrote:
> > Also you should at least clamp the values so that you don't end up
> > writing outside the frame buffer, I expect your patch will crash
> > reliably with e.g.
> > -geometry 0:10000
> > or
> > -geometry 0:-900
> > or
> > -geometry 800:10000
> > ...
> >
> Fair enough. I guess once I get this fixed properly, I should probably
> incorporate the same fixes at vo_fbdev, as well.

That would be good, I really dislike that the code might be overwriting
because this touches video RAM and thus might break more than just MPlayer.
I never managed to get fbdev(2) to work for me, so I never could fix all the
issues I suspect they have.