[MPlayer-dev-eng] [PATCH] -geometry support in vo_fbdev2

[Benson Mitchell]

On Fri, Jun 26, 2009 at 7:29 AM, Reimar Döffinger
<Reimar.Doeffinger at gmx.de>wrote:

> On Fri, Jun 26, 2009 at 06:26:43AM -0400, Benson Mitchell wrote:
> > This adds -geometry handling to fbdev2, basically copied from fbdev. The
> > implementation's not perfect (just like in fbdev), but works ok for sane
> > inputs.
>
> Ideally you should use the method recommended by DOCS/tech/libvo.txt:
> Implement VOCTRL_UPDATE_SCREENINFO and then use vo_dx, vo_dy, vo_dwidth
> and vo_height directly.
>
OK, I'll take a shot at implementing it that way.


> Also you should at least clamp the values so that you don't end up
> writing outside the frame buffer, I expect your patch will crash
> reliably with e.g.
> -geometry 0:10000
> or
> -geometry 0:-900
> or
> -geometry 800:10000
> ...
>
Fair enough. I guess once I get this fixed properly, I should probably
incorporate the same fixes at vo_fbdev, as well.