[MPlayer-dev-eng] Remove libass

[Diego Biurrun]

On Wed, Jul 22, 2009 at 12:55:42AM +0200, Grigori Goronzy wrote:
> Diego Biurrun wrote:
> >> There are a few possible problems.
> >> * It's not possible to statically link libass into the mplayer binary at
> >> the moment.
> > 
> > Why?
> 
> Mostly because it's not support by the build system yet.

I consider this a dealbreaker for now.

> >> +#ifndef LIBASS_MP_H
> >> +#define LIBASS_MP_H
> > 
> > This is not the correct multiple inclusion guard.
> 
> Not my fault. :-)

It is once you move the file.  Anyway, just fix it..

> >> +typedef struct {
> >> +    ass_image_t *imgs;
> >> +    int changed;
> >> +} mp_eosd_images_t;
> > 
> > Please avoid _t typedefs, the _t namespace is reserved by POSIX.
> 
> Not mine either.

Please don't add further namespace pollution.  And you could fix libass.
Avoiding namespace pollution is a good thing.


Evgeniy is the maintainer of libass (in MPlayer).  He needs to decide
the fate of this patch.

Diego