[MPlayer-dev-eng] [PATCH] - No Reset of D3D device on resize
gogothebee at gmail.com
Tue Jan 27 00:59:26 CET 2009
On Tue, Jan 27, 2009 at 12:20 AM, Reimar Döffinger
<Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:
> On Sun, Dec 28, 2008 at 07:08:33PM +0200, Georgi Petrov wrote:
>> I think this smooth resize patch is much better. Please, take a look.
>> I made less changes and the things are more logical now. I took into
>> account your suggestions and they turned out to be right.
> Well, I think the whole initialization code needs to be reworked.
> This patch reworks it already although it is not really necessary,
> nor does it fix all the issues (possible leaks).
> Unfortunately I just do not have time and inclination to fix it properly, nor to
> nit-pick every detail of this patch.
> So I can only suggest to apply it as is, and hope someone somewhen later comes
> up with a design that works also for the corner cases - any objections?
Great! Please apply it. I can always rework it to make it better, but
the patch makes it better for sure.
>> Why the D3DADAPTER_DEFAULT in preinit is not necessarily the one we
>> will be rendering on in the end?
> After a reinit possibly not (I think). Also in case of remote-desktop I
Interesting point. Anyway we'll have to resolve the MPlayer crash
problem (referred in the other thread, about uncooperative adapter) on
order to test it.
I can make a test about the remote desktop with my code (which doesn't
make MPlayer crash) to see if the adapter changes.
More information about the MPlayer-dev-eng