[MPlayer-dev-eng] [PATCH] - No Reset of D3D device on resize
Reimar Döffinger
Reimar.Doeffinger at stud.uni-karlsruhe.de
Mon Jan 26 23:20:55 CET 2009
On Sun, Dec 28, 2008 at 07:08:33PM +0200, Georgi Petrov wrote:
> I think this smooth resize patch is much better. Please, take a look.
> I made less changes and the things are more logical now. I took into
> account your suggestions and they turned out to be right.
Well, I think the whole initialization code needs to be reworked.
This patch reworks it already although it is not really necessary,
nor does it fix all the issues (possible leaks).
Unfortunately I just do not have time and inclination to fix it properly, nor to
nit-pick every detail of this patch.
So I can only suggest to apply it as is, and hope someone somewhen later comes
up with a design that works also for the corner cases - any objections?
> > Btw. while looking through the code under this aspect I realized
> > that the IDirect3D9_GetDeviceCaps in preinit really makes no sense,
> > since the D3DADAPTER_DEFAULT in preinit is not necessarily the one we
> > will be rendering on in the end.
>
> Why the D3DADAPTER_DEFAULT in preinit is not necessarily the one we
> will be rendering on in the end?
After a reinit possibly not (I think). Also in case of remote-desktop I
think.
Greetings,
Reimar Döffinger
More information about the MPlayer-dev-eng
mailing list