[MPlayer-dev-eng] [PATCH]VO_VDPAU, round 4

Diego Biurrun diego at biurrun.de
Thu Jan 22 09:30:11 CET 2009

On Thu, Jan 22, 2009 at 12:22:23AM +0000, Carl Eugen Hoyos wrote:
> Diego Biurrun <diego <at> biurrun.de> writes:
> > > > inconsistent formatting,
> > > 
> > > Do you see one outside of uninit()?
> > 
> > Brace placement is often inconsistent (K&R style preferred),
> This does only apply to function declarations, or am I wrong (I could not find a
> function that did not have its "{" on a new line)?

K&R style is more than just function declarations of course.

Specifically, it places a space after flow control keywords (if/while/..)
and the braces on the same line, i.e.

    if (condition) {

Just try running your file through indent with the proper options to
see the difference or look at the first hit Google produces for K&R
indent style.


More information about the MPlayer-dev-eng mailing list