[MPlayer-dev-eng] [PATCH] factorize print_version()

Diego Biurrun diego at biurrun.de
Mon Jan 12 13:02:08 CET 2009

On Mon, Jan 12, 2009 at 03:45:26AM +0200, Uoti Urpala wrote:
> On Mon, 2009-01-12 at 02:01 +0100, Diego Biurrun wrote:
> > Here is a patch to factorize the version string etc. output in mplayer.c
> > and mencoder.c.
> Do you have any motivation for this beyond just decreasing code
> duplication?

I stumbled across it while looking at the copyright year update patches
and the bugzilla entry 1378 about some information about CPU options not
being printed.  Yes, the motivation is to decrease the code duplication
and to avoid bugs like 1378 in the future.

> I don't really like it - I think MPlayer code quality is
> the most important thing, and from that viewpoint this way of splitting
> code between mplayer.c and mpcommon.c is IMO quite arbitrary and does
> not give a good architecture. If MEncoder is developed further then that
> would be best done by deleting most of its independent code and moving
> the encoding functionality to work with MPlayer's frame generation. If
> that is done it doesn't matter much what extra crap mencoder.c had.

I don't think MEncoder should be left to rot even more.  The way of code
splitting can be changed at any point easily.  The code duplication
causes issues now.


More information about the MPlayer-dev-eng mailing list