[MPlayer-dev-eng] [PATCH] factorize print_version()

Uoti Urpala uoti.urpala at pp1.inet.fi
Mon Jan 12 02:45:26 CET 2009

On Mon, 2009-01-12 at 02:01 +0100, Diego Biurrun wrote:
> Here is a patch to factorize the version string etc. output in mplayer.c
> and mencoder.c.

Do you have any motivation for this beyond just decreasing code
duplication? I don't really like it - I think MPlayer code quality is
the most important thing, and from that viewpoint this way of splitting
code between mplayer.c and mpcommon.c is IMO quite arbitrary and does
not give a good architecture. If MEncoder is developed further then that
would be best done by deleting most of its independent code and moving
the encoding functionality to work with MPlayer's frame generation. If
that is done it doesn't matter much what extra crap mencoder.c had.

More information about the MPlayer-dev-eng mailing list