[MPlayer-dev-eng] [PATCH] vo_macosx: fix device_id option after r28165

Adrian Stutz adrian at sttz.ch
Fri Jan 9 16:34:12 CET 2009

On Fri, Jan 9, 2009 at 4:20 PM, Guillaume POIRIER <poirierg at gmail.com>wrote:

> I'm not a big fan of using special values to change the behaviour of
> an option, such as here device_id=-1, but I'll let others comment on
> that before taking any decision.

It's the default behavior, which is usually better selected by not setting

I considered leaving the non-negative constraint for device_id but opted to
remove it since it is a little easier to use the option for GUI frontends or
shell scripts this way.

You can also look at it this way: -1 does not change the behavior but rather
means: "not set - use default"

But I don't feel strongly for allowing this special value. I can change it
back to the way it was, if that's preferred.


More information about the MPlayer-dev-eng mailing list