[MPlayer-dev-eng] [PATCH] vo_macosx: fix device_id option after r28165

Guillaume POIRIER poirierg at gmail.com
Fri Jan 9 16:20:38 CET 2009


On Fri, Jan 9, 2009 at 4:03 PM, Adrian Stutz <adrian at sttz.ch> wrote:
> I missed the screen_force BOOL in my patch to vo_macosx to replace the
> custom options parsing with subopt_parse().
> Because screen_force is never set to YES anymore, the device_id option has
> no effect on fullscreen.
> The attached patch fixes that and removes screen_force, since screen_id is
> only used to force fullscreen anyway. The patch instead allows screen_id to
> be negative for automatic fullscreen device selection and assumes a forced
> selection for any positive value.
> Patch also includes update of the manpage that includes the new negative
> value of device_id.

Thanks for the patch. I noticed last week-end that device_id wasn't
working, but didn't know if it ever worked reliably (hence my post to
mplayer-users http://article.gmane.org/gmane.comp.video.mplayer.user/59082)

I'm not a big fan of using special values to change the behaviour of
an option, such as here device_id=-1, but I'll let others comment on
that before taking any decision.

Only a very small fraction of our DNA does anything; the rest is all
comments and ifdefs.

Steve Martin  - "I like a woman with a head on her shoulders. I hate necks."

More information about the MPlayer-dev-eng mailing list