[MPlayer-dev-eng] [PATCH] update ao_jack to use jack_client_open

[Reimar Döffinger]

On Sun, Jan 04, 2009 at 06:54:07AM +0000, Alex Sisson wrote:
> This means that now that if jackd is not running, and mplayer is started with -ao jack, then jack will automatically be started, which I think is a good thing

If it worked. I just tested it, about 2 out of 3 times it will just
print

> JACK compiled with System V SHM support.
> loading driver ..
> creating alsa driver ...  hw:0|hw:0|1024|2|48000|0|0|nomon|swmeter|-|32bit
> control device hw:0
> [JACK] no physical ports available

And even when it actually works there is about 3 seconds delay where
MPlayer just hangs waiting for something.
Unless that is a bug that nobody else can reproduce, this is not an
option that is stable enough to be acceptable to enable by default.

> The possible bad thing about this is that if jackd is started in this way, it prints its own messages.

Well, I can see some reasons why they did it like that, but the way I learned it a library
printing to stdout without providing API to output it somehow else
is a sign of a bad or sloppy programmer...

Greetings,
Reimar Döffinger