[MPlayer-dev-eng] [PATCH] update ao_jack to use jack_client_open
Reimar.Doeffinger at stud.uni-karlsruhe.de
Sun Jan 4 12:14:08 CET 2009
On Sun, Jan 04, 2009 at 06:54:07AM +0000, Alex Sisson wrote:
> The JACK documentation at http://jackaudio.org/files/docs/html/group__ClientFunctions.html mentions that jack_client_new is deprecated and so I have updated ao_jack.c to use jack_client_open with no arguments.
Removing the documentation for deprecated functions is idiocy, it makes
porting old applications hard for no good reason.
> This means that now that if jackd is not running, and mplayer is started with -ao jack, then jack will automatically be started, which I think is a good thing - it is annoying that other jack apps start it automatically but not mplayer,
That's not the only change, you need to use JackUseExactName to keep the
current behaviour I think.
> The possible bad thing about this is that if jackd is started in this way, it prints its own messages.
Setting JACK_NO_START_SERVER in the process environment when starting
MPlayer should get the old behaviour back it seems to me.
Obviously that should be in the documentation.
More information about the MPlayer-dev-eng