[MPlayer-dev-eng] [PATCH] vo_kva

[KO Myung-Hun]

Hi/2.

Reimar Döffinger wrote:
> On Thu, Feb 26, 2009 at 01:18:15AM +0900, KO Myung-Hun wrote:
>   
>> flip_page() transfers the contents of the frame of the internal buffer 
>> to the video buffer allocated by video hw and displays them. But 
>> draw_slice() copys the contents to the internal buffer.
>>
>> And as you see, kvaLockBuffer() allocate a video buffer and 
>> kvaUnlockBuffer() display the contents of the video buffer. So I cannot 
>> use a video buffer in draw_slice().
>>     
>
> You can call kvaLockBuffer during VOCTRL_START_SLICE (or draw_frame)
> and call kvaUnlockBuffer in flip_page.
> Gets rid of the internal buffer, should be a lot faster, and displays
> the video much closer to the right moment.
> While that it is quite contrary to common sense to keep something locked
> for such a long time, this seems to be the way that kva (and some other
> OS/2 video interfaces) was designed.
>   

I've tested with a quick implemetation, and found some problems.

1. VOCTRL_START_SLICE is sometimes not called. Instead draw_slice is 
called prior to it.

2. While OSD is displaying, performance is decreased very much.

3. OSD is flickering.

Any suggestion ?

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 1.1.14
Under OS/2 Warp 4 for Korean with FixPak #15
On AMD ThunderBird 1 GHz with 512 MB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr