[MPlayer-dev-eng] [PATCH] vo_kva

[Diego Biurrun]

On Thu, Feb 26, 2009 at 12:00:23AM +0900, KO Myung-Hun wrote:
> 
> This patch adds a vo_kva for OS/2 video system.
> 
> --- libvo/vo_kva.c	(revision 0)
> +++ libvo/vo_kva.c	(revision 0)
> @@ -0,0 +1,1194 @@
> +
> +typedef struct tagVOKVAINTERNAL {
> +} VOKVAINTERNAL, *PVOKVAINTERNAL;

typedefs are ugly..

> +extern void mplayer_put_key(int code);            // let mplayer handel the keyevents

handLe

Forward declarations are ugly, please #include the appropriate
header instead.

> +static VOID imgCreate(VOID)

VOID?

> +            //if (ustflags & (TF_LEFT | TF_RIGHT | TF_TOP | TF_BOTTOM | TF_SETPOINTERPOS))
> +            {
> +            #if 0
> +                pti->rclBoundary.xLeft   = 0;
> +                pti->rclBoundary.yBottom = 0;
> +                pti->rclBoundary.xRight  = vo_screenwidth;
> +                pti->rclBoundary.yTop    = vo_screenheight;
> +            #endif

What is this disabled code good for?  If it's good for nothing, get rid
of it.

> +static void uninit(void)

Now it's plain 'void'.  I think the lowercase version is preferable.

> +static int config(uint32_t width, uint32_t height, uint32_t d_width, uint32_t d_height, uint32_t flags, char *title, uint32_t format)

Please break such long lines, same in other places.

Diego