[MPlayer-dev-eng] [PATCH] vo_kva

KO Myung-Hun komh at chollian.net
Wed Feb 25 17:50:58 CET 2009


Hi/2.

Georgi Petrov wrote:
>> Ok. But VOCTRL_SET_EQUALIZER/VOCTRL_GET_EQUALIZER have a separate function.
>>
>> A complete separation is needed ?
>>     
>
> I was suggesting that no specific code is present in control(), but
> everything is handled by calling small static functions. This way
> control() is kept as simple as possible.
>   

I agree.

> VOCTRL_SET_EQUALIZER/VOCTRL_GET_EQUALIZER are not so big, but the
> fullscreen code should be separated IMHO. 

Ok.  ^^

> When Reimar has time, he
> will give you the best advices.
>   

I wish that, too.

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 1.1.14
Under OS/2 Warp 4 for Korean with FixPak #15
On AMD ThunderBird 1 GHz with 512 MB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr





More information about the MPlayer-dev-eng mailing list